From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw
Date: Wed, 21 Dec 2016 13:08:53 -0500
Message-ID: <1312.1482343733@sss.pgh.pa.us> (raw)
In-Reply-To: <21630.1482341251@sss.pgh.pa.us>
References: <19872.1482338965@sss.pgh.pa.us>
<dfa45c48-659c-caa8-76de-06006707c3aa@joeconway.com>
<21630.1482341251@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
>>> I propose that we should change that string to "could not obtain message
>>> string for error on connection "foo"", or something along that line.
BTW, looking closer, I notice that the dblink case already has
errcontext("Error occurred on dblink connection named \"%s\": %s.",
dblink_context_conname, dblink_context_msg)));
so we probably don't need the connection name in the primary error
message. Now I think "could not obtain message string for remote error"
would be a sufficient message.
In the postgres_fdw case, I'd be inclined to use the same replacement
primary message. Maybe we should think about adding the server name
to the errcontext there, but that seems like an independent improvement.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, mail@joeconway.com
Subject: Re: Getting rid of "unknown error" in dblink and postgres_fdw
In-Reply-To: <1312.1482343733@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox