From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Reducing the runtime of the core regression tests
Date: Thu, 11 Apr 2019 12:55:04 -0400
Message-ID: <13132.1555001704@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wz=KzsQzcUiFd=TPsnOmrB1=FFxNkq3NigG2umEN=n2GCQ@mail.gmail.com>
References: <735.1554935715@sss.pgh.pa.us>
<CAH2-WznCYL49ci=Gvq-WqRoTOESBfNCkQRbw=zzJ-zRrp6dedQ@mail.gmail.com>
<32387.1554938378@sss.pgh.pa.us>
<CAH2-WzkgZZ2od_4ScQfmzB9wZ+aPqq8LGL5rYdqv1pA-HYJgFQ@mail.gmail.com>
<CAH2-Wz=KzsQzcUiFd=TPsnOmrB1=FFxNkq3NigG2umEN=n2GCQ@mail.gmail.com>
Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Apr 10, 2019 at 4:56 PM Peter Geoghegan <pg@bowt.ie> wrote:
>> The original fastpath tests don't seem particularly effective to me,
>> even without the oversight I mentioned. I suggest that you remove
>> them, since the minimal btree_index.sql fast path test is sufficient.
> To be clear: I propose that you remove the tests entirely, and we
> leave it at that. I don't intend to follow up with my own patch
> because I don't think that there is anything in the original test case
> that is worth salvaging.
I checked into this by dint of comparing "make coverage" output for
"make check" runs with and without indexing.sql's fastpath tests.
There were some differences that seem mostly to be down to whether
or not autovacuum hit particular code paths during the test run.
In total, I found 29 lines that were hit in the first test but not
in the second ... and 141 lines that were hit in the second test
but not the first. So I concur that indexing.sql's fastpath test
isn't adding anything useful coverage-wise, and will just nuke it.
(It'd be interesting perhaps to check whether the results shown
by coverage.postgresql.org are similarly unstable. They might be
less so, since I believe those are taken over the whole check-world
suite not just the core regression tests.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-hackers@lists.postgresql.org
Subject: Re: Reducing the runtime of the core regression tests
In-Reply-To: <13132.1555001704@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox