From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: PoC/WIP: Extended statistics on expressions
Date: Mon, 18 Jan 2021 00:26:17 +0100
Message-ID: <131b0d63-5ab8-6fa4-fb77-cd0bc23d5e23@enterprisedb.com> (raw)
In-Reply-To: <20210117052954.GC8560@telsasoft.com>
References: <CAEZATCWGYooC_Tzt8sQo7760ZEsguj0JGoMLhkANrDwJ9CY20Q@mail.gmail.com>
<2567ae7e-e1dd-48b5-054d-ed6ff81c0335@enterprisedb.com>
<CAEZATCW_7nfeHmLtV6TzSfmFG+i=io_Qo0NL8BiBnmEqq3CQnQ@mail.gmail.com>
<CAEZATCUfMM43sv+RFDqyczQpYMP7SZLd4EexFEEUX4buWRNnrw@mail.gmail.com>
<afcd65d7-7701-a469-b064-9c62d63ef437@enterprisedb.com>
<20210108023537.GA19743@telsasoft.com>
<d7c93270-20a0-93cb-f15e-46d7b51b35c1@enterprisedb.com>
<5305f9cf-3927-06c4-cd5b-e46cbc58bc7f@enterprisedb.com>
<20210116232208.GB8560@telsasoft.com>
<2f2a3b3b-93e4-723f-144e-bc21f10d6b61@enterprisedb.com>
<20210117052954.GC8560@telsasoft.com>
On 1/17/21 6:29 AM, Justin Pryzby wrote:
> On Sun, Jan 17, 2021 at 01:23:39AM +0100, Tomas Vondra wrote:
>> diff --git a/doc/src/sgml/ref/create_statistics.sgml b/doc/src/sgml/ref/create_statistics.sgml
>> index 4363be50c3..5b8eb8d248 100644
>> --- a/doc/src/sgml/ref/create_statistics.sgml
>> +++ b/doc/src/sgml/ref/create_statistics.sgml
>> @@ -21,9 +21,13 @@ PostgreSQL documentation
>>
>> <refsynopsisdiv>
>> <synopsis>
>> +CREATE STATISTICS [ IF NOT EXISTS ] <replaceable class="parameter">statistics_name</replaceable>
>> + ON ( <replaceable class="parameter">expression</replaceable> )
>> + FROM <replaceable class="parameter">table_name</replaceable>
>
>> CREATE STATISTICS [ IF NOT EXISTS ] <replaceable class="parameter">statistics_name</replaceable>
>> [ ( <replaceable class="parameter">statistics_kind</replaceable> [, ... ] ) ]
>> - ON <replaceable class="parameter">column_name</replaceable>, <replaceable class="parameter">column_name</replaceable> [, ...]
>> + ON { <replaceable class="parameter">column_name</replaceable> | ( <replaceable class="parameter">expression</replaceable> ) } [, ...]
>> FROM <replaceable class="parameter">table_name</replaceable>
>> </synopsis>
>
> I think this part is wrong, since it's not possible to specify a single column
> in form#2.
>
> If I'm right, the current way is:
>
> - form#1 allows expression statistics of a single expression, and doesn't
> allow specifying "kinds";
>
> - form#2 allows specifying "kinds", but always computes expression statistics,
> and requires multiple columns/expressions.
>
> So it'd need to be column_name|expression, column_name|expression [,...]
>
Strictly speaking you're probably correct - there should be at least two
elements. But I'm somewhat hesitant about making this more complex,
because it'll be harder to understand.
>> @@ -39,6 +43,16 @@ CREATE STATISTICS [ IF NOT EXISTS ] <replaceable class="parameter">statistics_na
>> database and will be owned by the user issuing the command.
>> </para>
>>
>> + <para>
>> + The <command>CREATE STATISTICS</command> command has two basic forms. The
>> + simple variant allows building statistics for a single expression, does
>> + not allow specifying any statistics kinds and provides benefits similar
>> + to an expression index. The full variant allows defining statistics objects
>> + on multiple columns and expressions, and selecting which statistics kinds will
>> + be built. The per-expression statistics are built automatically when there
>> + is at least one expression.
>> + </para>
>
>> + <varlistentry>
>> + <term><replaceable class="parameter">expression</replaceable></term>
>> + <listitem>
>> + <para>
>> + The expression to be covered by the computed statistics. In this case
>> + only a single expression is required, in which case only the expression
>> + statistics kind is allowed. The order of expressions is insignificant.
>
> I think this part is wrong now ?
> I guess there's no user-facing expression "kind" left in the CREATE command.
> I guess "in which case" means "if only one expr is specified".
> "expression" could be either form#1 or form#2.
>
> Maybe it should just say:
>> + An expression to be covered by the computed statistics.
>
> Maybe somewhere else, say:
>> In the second form of the command, the order of expressions is insignificant.
>
Yeah, this is a leftover from when there was "expressions" kind. I'll
reword this a bit.
thanks
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@enterprisedb.com, pryzby@telsasoft.com, dean.a.rasheed@gmail.com
Subject: Re: PoC/WIP: Extended statistics on expressions
In-Reply-To: <131b0d63-5ab8-6fa4-fb77-cd0bc23d5e23@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox