From: Alexander Lakhin <exclusion@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: make installcheck-world in a clean environment
Date: Thu, 12 Jul 2018 15:32:00 +0300
Message-ID: <13311de0-456c-fe1e-3e61-9bdf916ef1a2@gmail.com> (raw)
In-Reply-To: <16109.1531340141@sss.pgh.pa.us>
References: <bfee872b-ab16-ec7c-8f8a-b3949add1c1b@gmail.com>
<CA+TgmoafXiYMj6ROd09PxLFQ_dpurP1FJOL4ZwDonCkPeSubWg@mail.gmail.com>
<aff02bd6-20c9-0b6e-4e3c-a3428ce6568b@gmail.com>
<CA+TgmoZV08_6SXmag0hFkOurgWPjks6Jwyh+DeFXsCxLWLVjfw@mail.gmail.com>
<24834.1525712835@sss.pgh.pa.us>
<ec02a440-0346-4bdc-5118-0f7970d33c16@gmail.com>
<b36c96e5-05cf-aa0f-90a5-2276887170ce@2ndquadrant.com>
<beb142a3-aaf6-f6d7-2aae-69f7d65fb3d4@gmail.com>
<16109.1531340141@sss.pgh.pa.us>
Hello Tom,
11.07.2018 23:15, Tom Lane wrote:
>
>> /make clean/
>> # Also you can just install binary packages to get the same state.
>> make installcheck-world
>> # This check fails.
> I do not think that should be expected to work. It would require that
> "make installcheck" first invoke "make all" (to rebuild the stuff you
> threw away with "make clean"), which is rather antithetical to its
> purpose. Specifically, installcheck is supposed to be checking something
> you already built; so having it do a fresh build seems to introduce
> version-skew hazards that we don't need.
If I understand correctly, the installcheck target should not use the
stuff in the build directory (that is thrown away with 'make clean'),
but instead should use/check the installed assets.
In fact with REL_10_STABLE you can run "make clean && make installcheck"
and it works just fine (without calling 'make all'). It's sufficient to
have a working instance running. And I think, this behavior is correct —
"installcheck" supposed to check not something we built ("check" is
supposed to do that), but something we installed.
And only if I run "make installcheck-world" with REL_10_STABLE I get an
error related to ECPG, I've referred to in the first message in this thread.
In the master branch there was some changes that prevent "make clean &&
make installcheck" scenario to run, but I think it can (and should) be
fixed too.
(When I prepared the patches, there were no differences between these
branches in this aspect.)
So for me the question is what assets should the installcheck target be
checking? Installed or built ones? For example, if psql/pg_dump/ecpg/...
is installed in /usr/local/pgsql/bin/, should it be checked by the
installcheck? And if we target the installed stuff then why do we need
to build something (or have something built) for installcheck?
Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com
Subject: Re: make installcheck-world in a clean environment
In-Reply-To: <13311de0-456c-fe1e-3e61-9bdf916ef1a2@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox