From: Peter Eisentraut <peter_e@gmx.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Thom Brown <thom@linux.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Subject: Re: Command Triggers, patch v11
Date: Mon, 19 Mar 2012 18:53:21 +0200
Message-ID: <1332176001.8435.1.camel@vanquo.pezone.net> (raw)
In-Reply-To: <24506.1332119786@sss.pgh.pa.us>
References: <m24nufq466.fsf@2ndQuadrant.fr>
<201203162237.38813.andres@anarazel.de>
<21818.1331934775@sss.pgh.pa.us>
<201203162317.43818.andres@anarazel.de>
<7094.1331996567@sss.pgh.pa.us>
<9503.1332006327@sss.pgh.pa.us>
<24814.1332021870@sss.pgh.pa.us>
<1332107267.6915.2.camel@vanquo.pezone.net>
<24506.1332119786@sss.pgh.pa.us>
On sön, 2012-03-18 at 21:16 -0400, Tom Lane wrote:
> If we were going to change the output at all, I would vote for "CREATE
> TABLE nnnn" so as to preserve the rowcount functionality. Keep in
> mind though that this would force client-side changes, for instance in
> libpq's PQcmdTuples(). Fixing that one routine isn't so painful, but
> what of other client-side libraries, not to mention applications?
Doesn't seem worth it to me. At least, "SELECT nnnn" makes some sense:
nnnn rows were selected. "CREATE TABLE nnnn" means what? nnnn tables
were created?
What might make sense is to delegate this additional information to
separate fields in a future protocol revision.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter_e@gmx.net, tgl@sss.pgh.pa.us, andres@anarazel.de, thom@linux.com, dimitri@2ndquadrant.fr
Subject: Re: Command Triggers, patch v11
In-Reply-To: <1332176001.8435.1.camel@vanquo.pezone.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox