From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: Shubham Khanna <khannashubham1197@gmail.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Assorted typo fixes
Date: Wed, 03 Jan 2024 00:56:58 -0500
Message-ID: <133580.1704261418@sss.pgh.pa.us> (raw)
In-Reply-To: <ZZTx7y0gPI9SfCIa@paquier.xyz>
References: <87le9fmi01.fsf@wibble.ilmari.org>
<CAHv8RjKqCANyFnXbCVoGz-OXVW30HO=KzbSvwmU67tfJTHn48g@mail.gmail.com>
<87frzgmz8b.fsf@wibble.ilmari.org>
<CA+Tgmob-0ybwZPMb=AEckTP9wna8Em-nPVW_VXPdqNOLwJs6dQ@mail.gmail.com>
<ZZTx7y0gPI9SfCIa@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> 0010 is indeed the "correct" plural form for vertex I've known but
> "vertexes" is not wrong either. Perhaps that's worth changing on
> consistency grounds?
Yeah. A quick grep shows that we have 16 uses of "vertices" and
only this one of "vertexes". It's not really wrong, but +1 for
making it match the others.
> 8)</literal>, must be identical. It doesn't matter which representation
> you choose to be the canonical one, so long as two equivalent values with
> - different formattings are always mapped to the same value with the same
> + different formatting are always mapped to the same value with the same
> formatting.
> I am not sure about this one in 0011 though.. It also feels like this
> could be reworded completely.
I'd leave this alone, it's not wrong either. If you want to propose
a complete rewording, do so; but that's not "misspelling" territory.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, robertmhaas@gmail.com, ilmari@ilmari.org, khannashubham1197@gmail.com, andres@anarazel.de
Subject: Re: Assorted typo fixes
In-Reply-To: <133580.1704261418@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox