From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Dubious code in pg_rewind's process_target_file()
Date: Sun, 06 Sep 2020 11:06:59 -0400
Message-ID: <1364691.1599404819@sss.pgh.pa.us> (raw)
In-Reply-To: <6ba44dc9-2b7e-1988-de4e-99832235eae5@iki.fi>
References: <1221796.1599329320@sss.pgh.pa.us>
<1222282.1599329909@sss.pgh.pa.us>
<6ba44dc9-2b7e-1988-de4e-99832235eae5@iki.fi>
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 05/09/2020 21:18, Tom Lane wrote:
>> Or actually, maybe we should just drop the lstat call altogether?
> Agreed, the lstat() doesn't do anything interesting.
> This is refactored away by the patches discussed at
> https://www.postgresql.org/message-id/f155aab5-1323-8d0c-9e3b-32703124bf00%40iki.fi.
> But maybe we should still clean it up in the back-branches.
Ah, I'd not been paying much attention to that work, but I
see you are getting rid of the lstat().
I propose to remove the lstat() in the back branches, but not touch
HEAD so as not to cause extra merge effort for your patch.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, hlinnaka@iki.fi, pgsql-hackers@lists.postgresql.org
Subject: Re: Dubious code in pg_rewind's process_target_file()
In-Reply-To: <1364691.1599404819@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox