pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Dubious code in pg_rewind's process_target_file()
Date: Sun, 06 Sep 2020 11:51:25 -0400
Message-ID: <1395091.1599407485@sss.pgh.pa.us> (raw)
In-Reply-To: <19145bdd-25a9-0ec5-2ec4-0e209e416dc8@iki.fi>
References: <1221796.1599329320@sss.pgh.pa.us>
	<1222282.1599329909@sss.pgh.pa.us>
	<6ba44dc9-2b7e-1988-de4e-99832235eae5@iki.fi>
	<1364691.1599404819@sss.pgh.pa.us>
	<19145bdd-25a9-0ec5-2ec4-0e209e416dc8@iki.fi>

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 06/09/2020 18:06, Tom Lane wrote:
>> I propose to remove the lstat() in the back branches, but not touch
>> HEAD so as not to cause extra merge effort for your patch.

> Thanks! Feel free to push it to HEAD, too, the merge conflict will be 
> trivial to resolve.

OK, done that way.

			regards, tom lane

view thread (6+ messages)

Message-ID: <1395091.1599407485@sss.pgh.pa.us>
Permalink:  ../1395091.1599407485@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1395091.1599407485@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, hlinnaka@iki.fi, pgsql-hackers@lists.postgresql.org
  Subject: Re: Dubious code in pg_rewind's process_target_file()
  In-Reply-To: <1395091.1599407485@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox