pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: TAP tests aren't using the magic words for Windows file access
Date: Sun, 03 Nov 2019 22:53:00 -0500
Message-ID: <13900.1572839580@sss.pgh.pa.us> (raw)

Buildfarm member drongo has been failing the pg_ctl regression test
pretty often.  I happened to look closer at what's happening, and
it's this:

could not read "C:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_ctl/tmp_check/t_004_logrotate_primary_data/pgdata/current_logfiles": Permission denied at C:/prog/bf/root/HEAD/pgsql.build/src/test/perl/TestLib.pm line 397.

That is, TestLib::slurp_file is failing to read a file.  Almost
certainly, "permission denied" doesn't really mean a permissions
problem, but failure to specify the file-opening flags needed to
allow concurrent access on Windows.  We fixed this in pg_ctl
itself in commit 0ba06e0bf ... but we didn't fix the TAP
infrastructure.  Is there an easy way to get Perl on board
with that?

			regards, tom lane





view thread (29+ messages)  latest in thread

Message-ID: <13900.1572839580@sss.pgh.pa.us>
Permalink:  ../13900.1572839580@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13900.1572839580@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: TAP tests aren't using the magic words for Windows file access
  In-Reply-To: <13900.1572839580@sss.pgh.pa.us>
  References: <13900.1572839580@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox