pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: WIP: Faster Expression Processing v4
Date: Fri, 24 Mar 2017 23:01:19 -0400
Message-ID: <13918.1490410879@sss.pgh.pa.us> (raw)
In-Reply-To: <22833.1490390175@sss.pgh.pa.us>
References: <28270.1490289299@sss.pgh.pa.us>
	<20170323174004.a2ez7kygx5ngqxlp@alap3.anarazel.de>
	<8011.1490305255@sss.pgh.pa.us>
	<26088.1490315792@sss.pgh.pa.us>
	<20170324004734.3a2dokbfofiz6ylu@alap3.anarazel.de>
	<30270.1490318779@sss.pgh.pa.us>
	<20170324013412.qy7ltnnqv5m7qiuc@alap3.anarazel.de>
	<31825.1490320683@sss.pgh.pa.us>
	<20170324020003.4rt63xty7xpb4akq@alap3.anarazel.de>
	<22215.1490369187@sss.pgh.pa.us>
	<20170324182742.3r4qndpugtx6ga3t@alap3.anarazel.de>
	<22833.1490390175@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

btw ... I just got around to looking at a code coverage report for this
patched version, and that reminded me of something I'd already suspected:
EEOP_INNER_SYSVAR and EEOP_OUTER_SYSVAR seem to be dead code.  That's
unsurprising, because we never try to access a tuple's system columns
above the scan level.  If a query asks for system columns, those get
passed up to upper query levels as ordinary user-side columns.

We could keep the execution support for those opcodes, or we could rip it
out and throw an error in execExpr.c if one would need to be generated.
I'm a little inclined to the latter, because it seems like the plan is
to grow more support for every opcode in the future.  We don't need to
be adding support for unreachable opcodes.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (107+ messages)  latest in thread

Message-ID: <13918.1490410879@sss.pgh.pa.us>
Permalink:  ../13918.1490410879@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/13918.1490410879@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, hlinnaka@iki.fi, tomas.vondra@2ndquadrant.com
  Subject: Re: WIP: Faster Expression Processing v4
  In-Reply-To: <13918.1490410879@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox