From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: array_cat anycompatible change is breaking xversion upgrade tests
Date: Wed, 04 Nov 2020 19:43:51 -0500
Message-ID: <1401824.1604537031@sss.pgh.pa.us> (raw)
crake is showing xversion upgrade failures since 9e38c2bb50:
pg_restore: error: could not execute query: ERROR: function array_cat(anyarray, anyarray) does not exist
Command was: CREATE AGGREGATE "public"."array_cat_accum"("anyarray") (
SFUNC = "array_cat",
STYPE = "anyarray",
INITCOND = '{}'
);
As was discussed in the thread leading up to that commit, modifying the
signature of array_cat and friends could break user-defined operators
and aggregates based on those functions. It seems to me that the
usability gain from this change is worth that cost, but it is causing
an issue for xversion tests.
I think the most plausible response is to add this aggregate to the filter
logic that already exists in the xversion tests. Perhaps we could
alternatively change this test case so that it relies on some other
polymorphic function, but I'm not quite sure what a good candidate
would be.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: array_cat anycompatible change is breaking xversion upgrade tests
In-Reply-To: <1401824.1604537031@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox