agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Thu, 08 Jan 2026 17:59:00 +0100
Message-ID: <141054.1767891540@localhost> (raw)
In-Reply-To: <11558.1767609632@localhost>
References: <202512151349.vlq3mpfniyk3@alvherre.pgsql>
<11247.1767609087@localhost>
<11558.1767609632@localhost>
Antonin Houska <ah@cybertec.at> wrote:
> Antonin Houska <ah@cybertec.at> wrote:
>
> > Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> > > If we do indeed need this,
> > > then perhaps it should be done after ReorderBufferProcessXid().
> >
> > ... and after SnapBuildProcessChange(). Thus the changes being discussed here
> > should be removed from the patch. I'll do that in the next version. Thanks.
>
> Actually the check of XLH_DELETE_NO_LOGICAL should not be discarded. I think
> it should be added to DecodeDelete().
v29 tries to fix the problem.
Besides that, it reflects the recent Mihail's comments [1], [2].
[1]
https://www.postgresql.org/message-id/CADzfLwXp4c-MJx7yVDxAGNNxPbX4o9dqyivxavtHvmUsdXYqBQ@mail.gmail...
[2] https://www.postgresql.org/message-id/CADzfLwWNz_jwi7KVOmJ9D97+zwxsiwDSqSUUJ9oqUCOqkbGnRA@mail.gmail...
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Attachments:
[text/x-diff] v29-0001-Add-REPACK-command.patch (0B, ../141054.1767891540@localhost/2-v29-0001-Add-REPACK-command.patch)
download
view thread (416+ messages) latest in thread
Message-ID: <141054.1767891540@localhost>
Permalink: ../141054.1767891540@localhost/
Also on: postgresql.org/message-id/141054.1767891540@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, alvherre@alvh.no-ip.org, mihailnikalayeu@gmail.com, pgsql-hackers@lists.postgresql.org, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <141054.1767891540@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox