public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Joel Jacobson <[email protected]>
Cc: Arseniy Mukhin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: [PATCH] Fix LISTEN startup race with direct advancement
Date: Tue, 26 May 2026 11:40:09 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CAE7r3ML+6-pokm+GHsfr+pJyZ_RUi=VY8Bp=qKx=3tcYunborA@mail.gmail.com>
<[email protected]>
<CAE7r3MLi9MRfysi+0AcEBzO-tR1PCDr40KT7E+Qgpa9WZHZhmg@mail.gmail.com>
<[email protected]>
"Joel Jacobson" <[email protected]> writes:
> Ohh, right, thanks for spotting. New version attached, 0001 and 0002 identical,
> and 0003 now only contain the fix.
I agree with this fix, but it seems to me that it changes the meaning
of the ListenerEntry.listening flag in a rather fundamental way.
I'm tempted to rename that flag to "committed" or something like that.
(Both "listening" and "committed" appear in dozens of places in this
file that are not references to this flag, so TBH I'd rather use a
flag name that is not either of those words. But I can't think of
a better name.)
Also, while the proposed test cases are good for showing that there's
a bug here, I'm disinclined to commit them. I do not think there is
value in them proportionate to the cost of two new isolation-test
instances.
regards, tom lane
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Fix LISTEN startup race with direct advancement
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox