pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Tightening up allowed custom GUC names
Date: Thu, 11 Feb 2021 13:32:53 -0500
Message-ID: <1477413.1613068373@sss.pgh.pa.us> (raw)
In-Reply-To: <20210209230155.GA551305@rfd.leadboat.com>
References: <951335.1612910077@sss.pgh.pa.us>
	<20210209230155.GA551305@rfd.leadboat.com>

Noah Misch <noah@leadboat.com> writes:
> On Tue, Feb 09, 2021 at 05:34:37PM -0500, Tom Lane wrote:
>> * A case could be made for tightening things up a lot more, and not
>> allowing anything that doesn't look like an identifier.  I'm not
>> pushing for that, as it seems more likely to break existing
>> applications than the narrow restriction proposed here.  But I could
>> live with it if people prefer that way.

> I'd prefer that.  Characters like backslash, space, and double quote have
> significant potential to reveal bugs, while having negligible application
> beyond revealing bugs.

Any other opinions here?  I'm hesitant to make such a change on the
basis of just one vote.

			regards, tom lane





view thread (9+ messages)  latest in thread

Message-ID: <1477413.1613068373@sss.pgh.pa.us>
Permalink:  ../1477413.1613068373@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1477413.1613068373@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Tightening up allowed custom GUC names
  In-Reply-To: <1477413.1613068373@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox