From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Tightening up allowed custom GUC names
Date: Wed, 07 Apr 2021 11:23:34 -0400
Message-ID: <1593065.1617809014@sss.pgh.pa.us> (raw)
In-Reply-To: <3053249.1615834191@sss.pgh.pa.us>
References: <951335.1612910077@sss.pgh.pa.us>
<20210209230155.GA551305@rfd.leadboat.com>
<1477413.1613068373@sss.pgh.pa.us>
<b7ef059e-4897-d2c2-62cb-7c5ebdc40f3e@dunslane.net>
<3053249.1615834191@sss.pgh.pa.us>
I wrote:
> We can't allow '-', for the specific reason that it won't work as a -c
> argument (thanks to -c's translation of '-' to '_'). The whole point here
> is to prevent corner cases like that. ':' would be all right, but I think
> it's a lot simpler to explain and a lot harder to break in future if we
> just say that the names have to be valid identifiers.
Hearing no further comments, I pushed the more restrictive version.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, noah@leadboat.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Tightening up allowed custom GUC names
In-Reply-To: <1593065.1617809014@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox