pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: SSL SNI
Date: Thu, 03 Jun 2021 13:52:41 -0400
Message-ID: <14840.1622742761@sss.pgh.pa.us> (raw)
In-Reply-To: <14368.1622742108@sss.pgh.pa.us>
References: <7289d5eb-62a5-a732-c3b9-438cee2cb709@enterprisedb.com>
	<ef3d4b460ae7da59a8811f4e8e8fde0cd38a6cc8.camel@vmware.com>
	<9407b344-7342-b2b7-004f-d5250687be42@enterprisedb.com>
	<ecb6a57d176a396feb959fbb0c53b3c794e8d8e5.camel@vmware.com>
	<4eaa2b56-c3d0-67b6-4716-010d001c7601@enterprisedb.com>
	<4bf3ae1c-b28e-8960-e89f-c390c5cf01a2@enterprisedb.com>
	<504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com>
	<14368.1622742108@sss.pgh.pa.us>

I wrote:
> Jacob Champion <pchampion@vmware.com> writes:
>> It looks like this code needs some guards for a NULL conn->pghost. For example when running
>> psql 'dbname=postgres sslmode=require hostaddr=127.0.0.1'
>> with no PGHOST in the environment, psql is currently segfaulting for
>> me.

> Duplicated here:

It looks like the immediate problem can be resolved by just adding
a check for conn->pghost not being NULL, since the comment above
says

     * Per RFC 6066, do not set it if the host is a literal IP address (IPv4
     * or IPv6).

and having only hostaddr certainly fits that case.  But I didn't
check to see if any more problems arise later.

			regards, tom lane

view thread (24+ messages)  latest in thread

Message-ID: <14840.1622742761@sss.pgh.pa.us>
Permalink:  ../14840.1622742761@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/14840.1622742761@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pchampion@vmware.com
  Subject: Re: SSL SNI
  In-Reply-To: <14840.1622742761@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox