pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Rethinking autovacuum.c memory handling
Date: Sat, 23 Sep 2017 13:28:56 -0400
Message-ID: <14871.1506187736@sss.pgh.pa.us> (raw)
In-Reply-To: <CAB7nPqTosuvT2Pjz5136jAi2+h0gGsYynuUP52Ejrw=JKXxi-Q@mail.gmail.com>
References: <13849.1506114543@sss.pgh.pa.us>
	<CAB7nPqTosuvT2Pjz5136jAi2+h0gGsYynuUP52Ejrw=JKXxi-Q@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Michael Paquier <michael.paquier@gmail.com> writes:
> I have spent some time looking at your patch and testing it. This
> looks sane. A small comment that I have would be to add an assertion
> at the top of perform_work_item to be sure that it is called in the
> memory context of AutovacMemCxt.

Done like that, thanks for reviewing!

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (9+ messages)  latest in thread

Message-ID: <14871.1506187736@sss.pgh.pa.us>
Permalink:  ../14871.1506187736@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/14871.1506187736@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael.paquier@gmail.com, alvherre@2ndquadrant.com
  Subject: Re: Rethinking autovacuum.c memory handling
  In-Reply-To: <14871.1506187736@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox