From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: "debug_invalidate_system_caches_always" is too long
Date: Mon, 05 Jul 2021 15:13:41 -0400
Message-ID: <1492832.1625512421@sss.pgh.pa.us> (raw)
In-Reply-To: <20210704211234.GD2421985@rfd.leadboat.com>
References: <1374320.1625430433@sss.pgh.pa.us>
<20210704211234.GD2421985@rfd.leadboat.com>
Noah Misch <noah@leadboat.com> writes:
> On Sun, Jul 04, 2021 at 04:27:13PM -0400, Tom Lane wrote:
>> However, I think we should also give serious consideration to
>> "debug_clobber_cache" or "debug_clobber_cache_always" for continuity
>> with past practice (though it still feels like "always" is a good
>> word to lose now). "debug_clobber_caches" is another reasonable
>> variant.
> https://en.wikipedia.org/wiki/Clobbering refers to cases where storage had no
> changes to its accessibility but now contains different data. That doesn't
> match InvalidateSystemCaches() especially well, so I think dropping that word
> has been a good step. Some other shorter terms could be debug_flush_caches,
> debug_rebuild_caches, or debug_expire_caches. (debug_caches is tempting, but
> that may ensnare folks looking for extra logging rather than a big slowdown.)
I like "debug_flush_caches" --- it's short and accurate.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-hackers@lists.postgresql.org
Subject: Re: "debug_invalidate_system_caches_always" is too long
In-Reply-To: <1492832.1625512421@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox