From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Álvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Printing window function OVER clauses in EXPLAIN
Date: Tue, 11 Mar 2025 11:21:00 -0400
Message-ID: <1499768.1741706460@sss.pgh.pa.us> (raw)
In-Reply-To: <CAApHDvpepuvR5jDq0rH_KzKbTA6+LuSWOgWG2thFDwvtnjyk_w@mail.gmail.com>
References: <202503100608.ktmgfoerjfqs@alvherre.pgsql>
<865427.1741623509@sss.pgh.pa.us>
<CAApHDvpepuvR5jDq0rH_KzKbTA6+LuSWOgWG2thFDwvtnjyk_w@mail.gmail.com>
David Rowley <dgrowleyml@gmail.com> writes:
> The only minor points I noted down while reviewing were 1)
> name_active_windows()'s newname variable could be halved in size and,
> 2) explain.sql's new test could name the window "w1" instead of "w" to
> exercise the name selection code a bit better. Both are minor points,
> but I thought I'd mention them anyway.
Thanks, pushed with those points addressed.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Printing window function OVER clauses in EXPLAIN
In-Reply-To: <1499768.1741706460@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox