public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: David G. Johnston <[email protected]>
Cc: Pavel Luzanov <[email protected]>
Cc: [email protected] <[email protected]>
Cc: David Zhang <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: psql: Add role's membership options to the \du+ command
Date: Tue, 04 Apr 2023 12:13:10 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwZeayTSQSVBFRAohND2or2izUMrCBfwvme6=YW9pQmexg@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAKFQuwbmAFfDw9ScCiOxK4UGf8Z8ny1nDgAn41gOJCeJ76QC4Q@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAKFQuwYZ3S_A1ZKdnmOv-LueO1683UZf7AocNFTDjwEMLVfMOA@mail.gmail.com>
	<[email protected]>
	<CAKFQuwbkywHVFPL6TrJiHFd0KgEvdH0LZTSFxAdK4wzP-u8m-A@mail.gmail.com>
	<[email protected]>
	<CAKFQuwY9DtC8B-eCpHe39yK+y9LardAyaEz0ccVa_pQ+xBgr2Q@mail.gmail.com>
	<[email protected]>
	<CAKFQuwb6u62n=eq2ZXq6mbVTpqWR2bz_QhmLjWrQ89Kcoi5x+g@mail.gmail.com>
	<CAKFQuwZTK7z=+rJkgbaZE=4H6FPxBJhbXBvKuR7e_vUXbPQEZw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<80fb0807-b55b-ccda-7f74-d7d! [email protected]>
	<CAKFQuwZeayTSQSVBFRAohND2or2izUMrCBfwvme6=YW9pQmexg@mail.gmail.com>

"David G. Johnston" <[email protected]> writes:
> I've marked this Ready for Committer.

Hmm ... not sure I like the proposed output.  The 'a', 'i', 's'
annotations are short but they don't have much else to recommend them.
On the other hand, there's nearby precedent for single-letter
abbreviations in ACL displays.  Nobody particularly likes those,
though.  Also, if we're modeling this on ACLs then the display
could be further shortened to "(ais)" or the like.

Also, the patch is ignoring i18n issues.  I suppose if we stick with
said single-letter abbreviations we'd not translate them, but the
construction "rolename from rolename" ought to be translatable IMO.
Perhaps it'd be enough to allow replacement of "from", but I wonder
if the phrase order would need to be different in some languages?

			regards, tom lane

view thread (29+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: psql: Add role's membership options to the \du+ command
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox