From: R, Siva <sivasubr@amazon.com>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages
Date: Thu, 19 Jul 2018 15:17:09 +0000
Message-ID: <1532013429633.24570@amazon.com> (raw)
In-Reply-To: <CAPpHfduzgM_YtgFMDRFwEtD2GbR9McPfGDRA1+Zcc6NvMQxxxw@mail.gmail.com>
References: <1531867212836.63354@amazon.com>
<CAPpHfdu9p8fpNsBCcdYxhBpXhe2_g3CDKjTKhh5BCEDuz6JdiA@mail.gmail.com>
<CAPpHfds627C9L-qSOBMqg3-L7Diha5vuaOFSRNE2J5XF3wwsDA@mail.gmail.com>
<CAPpHfduzgM_YtgFMDRFwEtD2GbR9McPfGDRA1+Zcc6NvMQxxxw@mail.gmail.com>
Hi Alexander!
> On Thu, Jul 19, 2018 at 2:43 PM Alexander Korotkov <a.korotkov@postgrespro.ru> wrote:
> It appears that we need to handle empty posting list pages also in disassembleLeaf(). Updated patch is attached. I'm
> going to commit it.
Thank you so much for reviewing the patch! You are right, we need to handle the regular insert/vacuum path for the empty page as well, thanks for fixing that. The updated patch looks good to me.
>BTW, what is your full name for the commit message?
My full name is "Sivasubramanian Ramasubramanian".
Email : sivasubr@amazon.com
Thanks again!
Best
Siva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sivasubr@amazon.com, a.korotkov@postgrespro.ru
Subject: Re: Bug in gin insert redo code path during re-compression of empty gin data leaf pages
In-Reply-To: <1532013429633.24570@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox