pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: [survey] New "Stable" QueryId based on normalized query text
Date: Wed, 20 Mar 2019 13:05:06 -0700 (MST)
Message-ID: <1553112306545-0.post@n3.nabble.com> (raw)
In-Reply-To: <20190320.104446.68838245.horiguchi.kyotaro@lab.ntt.co.jp>
References: <1553029215728-0.post@n3.nabble.com>
	<0A3221C70F24FB45833433255569204D1FBE20A4@G01JPEXMBYT05>
	<20190320.104446.68838245.horiguchi.kyotaro@lab.ntt.co.jp>

> From "Kyotaro HORIGUCHI-2"
>>At Wed, 20 Mar 2019 00:23:30 +0000, "Tsunakawa, Takayuki" 
>>> From: legrand legrand [mailto:legrand_legrand@]
>>> norm.9: comments aware
>> Is this to distinguish queries that have different comments for optimizer
>> hints?  If yes, I agree.

> Or, any means to give an explict query id? I saw many instances
> of query that follows a comment describing a query id.

Yes, in fact didn't thought about different kink of comments, but all of
them


>> needs.3: search_path / schema independant,

>pg_stat_statements even ignores table/object/column names.

there is a very interesting thread about that in "pg_stat_statements and non
default search_path"
https://www.postgresql.org/message-id/8f54c609-17c6-945b-fe13-8b07c0866420@dalibo.com

expecting distinct QueryIds when using distinct schemas ...
maybe that It should be switched to "Schema dependant"



>> needs.4: pg version independant (as long as possible),

>I don't think this cannot be guaranteed.

maybe using a QueryId versioning GUC 
 

>> norm.1: case insensitive
>> norm.2: blank reduction 
>> norm.3: hash algoritm ?
>> norm.4: CURRENT_DATE, CURRENT_TIME, LOCALTIME, LOCALTIMESTAMP not
>> normalized
>> norm.5: NULL, IS NULL not normalized ?
>> norm.6: booleans t, f, true, false not normalized
>> norm.7: order by 1,2 or group by 1,2 should not be normalized
>> norm.8: pl/pgsql anonymous blocks not normalized

> pg_stat_statements can be the base of the discussion on them.

OK

Regards
PAscal



--
Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html




view thread (26+ messages)  latest in thread

Message-ID: <1553112306545-0.post@n3.nabble.com>
Permalink:  ../1553112306545-0.post@n3.nabble.com/
Also on:    postgresql.org/message-id/1553112306545-0.post@n3.nabble.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: legrand_legrand@hotmail.com
  Subject: Re: [survey] New "Stable" QueryId based on normalized query text
  In-Reply-To: <1553112306545-0.post@n3.nabble.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox