pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Date: Wed, 27 Mar 2019 15:39:56 -0700 (MST)
Message-ID: <1553726396218-0.post@n3.nabble.com> (raw )
In-Reply-To: <CAOBaU_YY1paFNxPoeP7=WUZh5g92rSjMYLdnNqpNzyEiEAY9nw@mail.gmail.com >
References: <1550179299067-0.post@n3.nabble.com >
<2205341550215950@sas1-cd55e40a6ba0.qloud-c.yandex.net >
<DB6PR0301MB2135B4B1D256F547966A559B90430@DB6PR0301MB2135.eurprd03.prod.outlook.com >
<CAOBaU_Yq6motvaqXE_vBWf=SsRANij=+jE3Xa4qCmzGb24LkzA@mail.gmail.com >
<DB6PR0301MB21351B7CDA68EFE4838562EC905C0@DB6PR0301MB2135.eurprd03.prod.outlook.com >
<CAOBaU_bU1m3_XF5qKYtSj1ua4dxd=FWDyh2SH4rSJAUUfsGmAQ@mail.gmail.com >
<DB6PR0301MB2135B8CE071A02D2D663CFA1905F0@DB6PR0301MB2135.eurprd03.prod.outlook.com >
<CAOBaU_aX2Ad_pcSWGUQ1YFk8gotwoMYJDg5Wmosh7jj+28AQ4w@mail.gmail.com >
<1553718968249-0.post@n3.nabble.com >
<CAOBaU_YY1paFNxPoeP7=WUZh5g92rSjMYLdnNqpNzyEiEAY9nw@mail.gmail.com >
Julien Rouhaud wrote
> On Wed, Mar 27, 2019 at 9:36 PM legrand legrand
> <
> legrand_legrand@
> > wrote:
>>
>> >> - trailing whitespaces and comments wider than 80 characters
>> >> not fixed
>>
>> > why? In case it's not clear, I'm talking about the .c file, not the
>> > regression tests.
>>
>> I work on a poor msys install on windows 7, where perl is broken ;o(
>> So no pgindent available.
>> Will fix that later, or as soon as I get a pgindent diff.
>>
>> >> - "Assert(planning_time > 0 && total_time > 0);"
>> >> moved at the beginning of pgss_store
>>
>> > Have you tried to actually compile postgres and pg_stat_statements
>> > with --enable-cassert? This test can *never* be true, since you
>> > either provide the planning time or the execution time or neither. As
>> > I said in my previous mail, adding a parameter to say which counter
>> > you're updating, instead of adding another counter that's mutually
>> > exclusive with the other would make everything clearer.
>>
>> Yes this "assert" is useless as is ... I'll remove it.
>> I understand you proposal of pgss_store refactoring, but I don't have
>> much time available now ... and I would like to check that performances
>> are not broken before any other modification ...
>
> Ok, but keep in mind that this is the last commitfest for pg12, and
> there are only 4 days left. Will you have time to take care of it, or
> do you need help on it?
Oups, sorry, I won't have time nor knowledge to finish in time ;o(
Any help is welcome !
Regards
PAscal
--
Sent from: http://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html
view thread (127+ messages) latest in thread
Message-ID: <1553726396218-0.post@n3.nabble.com>
Permalink: ../1553726396218-0.post@n3.nabble.com/
Also on: postgresql.org/message-id/1553726396218-0.post@n3.nabble.com
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: legrand_legrand@hotmail.com
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
In-Reply-To: <1553726396218-0.post@n3.nabble.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox