pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Ants Aasma <ants.aasma@eesti.ee>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: WIP: Faster Expression Processing v4
Date: Mon, 27 Mar 2017 09:33:43 -0400
Message-ID: <15684.1490621623@sss.pgh.pa.us> (raw)
In-Reply-To: <20170327054314.qo6xsnlk7jcb7u2c@alap3.anarazel.de>
References: <22215.1490369187@sss.pgh.pa.us>
	<20170324182742.3r4qndpugtx6ga3t@alap3.anarazel.de>
	<22833.1490390175@sss.pgh.pa.us>
	<13918.1490410879@sss.pgh.pa.us>
	<5768.1490458935@sss.pgh.pa.us>
	<20170325222202.uz6evsjqrtwjnql6@alap3.anarazel.de>
	<CA+CSw_uq4OeY7i5u7=XeXXpJa0dMjfztP6FXrxQct-u=9vXJLA@mail.gmail.com>
	<3CC5B4C5-3ADB-4296-A04B-64F594A4CE4F@anarazel.de>
	<23529.1490500305@sss.pgh.pa.us>
	<20170326035927.5mubkfdtaqlrgm2d@alap3.anarazel.de>
	<20170327054314.qo6xsnlk7jcb7u2c@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
>> I personally find per-function annotation ala
>> __attribute__((optimize("no-crossjumping")))
>> cleaner anyway.  I tested that, and it seems to work.
>> 
>> Obviously we'd have to hide that behind a configure test.  Could also do
>> tests based on __GNUC__ / __GNUC_MINOR__, but that seems uglier.

Agreed.

> Checking for this isn't entirely pretty - see my attached attempt at
> doing so.  I considered hiding
> __attribute__((optimize("no-crossjumping"))) in execInterpExpr.c behind
> a macro (like PG_DISABLE_CROSSJUMPING), but I don't really think that
> makes things better.

I think it would, primarily because if we find out that some other compiler
spells this differently, we could handle it totally within configure.

Isn't our practice to put __attribute__ at the end of a function
declaration or definition, not in the middle someplace?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (107+ messages)  latest in thread

Message-ID: <15684.1490621623@sss.pgh.pa.us>
Permalink:  ../15684.1490621623@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/15684.1490621623@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, ants.aasma@eesti.ee, hlinnaka@iki.fi, tomas.vondra@2ndquadrant.com
  Subject: Re: WIP: Faster Expression Processing v4
  In-Reply-To: <15684.1490621623@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox