From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: headerscheck warnings with late-model gcc
Date: Thu, 07 Aug 2025 10:58:56 -0400
Message-ID: <1571545.1754578736@sss.pgh.pa.us> (raw)
In-Reply-To: <331f9ea7-8ddc-40c6-8a36-3e8994d3d3b3@eisentraut.org>
References: <1127775.1754417387@sss.pgh.pa.us>
<9b7ef918-302e-4c84-bc04-a37f5c2b5f92@eisentraut.org>
<1440669.1754507496@sss.pgh.pa.us>
<331f9ea7-8ddc-40c6-8a36-3e8994d3d3b3@eisentraut.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> Attached are three patches to fix some unrelated problems with
> headerscheck in my environment.
0001 seems fine; it's an oversight that I'd not noticed because
ICU_CFLAGS is empty in my usage.
Don't like 0002 as-is. I'd be okay with skipping that header if
--with-llvm isn't given. However, we already tell users that
they'd better configure --with-perl and --with-python, so maybe
just add --with-llvm to that list?
0003: +1, I noticed that too yesterday.
0004: I prefer the solution I exhibited yesterday, ie add
externs to those headers.
> kwlist_d.h doesn't show up in my run, probably because I'm using a
> separate build directory, which headerscheck doesn't handle? Another
> thing to fix.
Yeah, as it stands headerscheck is really only meant for in-tree
builds. We will definitely have to do something about that to make
it handle built headers in meson builds, and I guess it'd be nice if
VPATH works that way as well. One idea could be to redefine it as
searching the installation include-file tree instead of the source
tree, so that the build process washes out of the matter.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, pgsql-hackers@lists.postgresql.org
Subject: Re: headerscheck warnings with late-model gcc
In-Reply-To: <1571545.1754578736@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox