pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: headerscheck warnings with late-model gcc
Date: Fri, 29 Aug 2025 10:47:39 -0400
Message-ID: <2159707.1756478859@sss.pgh.pa.us> (raw)
In-Reply-To: <5101ab7b-e38b-4c56-b8b1-38655a5ecd6a@eisentraut.org>
References: <1127775.1754417387@sss.pgh.pa.us>
	<9b7ef918-302e-4c84-bc04-a37f5c2b5f92@eisentraut.org>
	<1440669.1754507496@sss.pgh.pa.us>
	<331f9ea7-8ddc-40c6-8a36-3e8994d3d3b3@eisentraut.org>
	<1571545.1754578736@sss.pgh.pa.us>
	<5101ab7b-e38b-4c56-b8b1-38655a5ecd6a@eisentraut.org>

Peter Eisentraut <peter@eisentraut.org> writes:
> On 07.08.25 16:58, Tom Lane wrote:
>> 0004: I prefer the solution I exhibited yesterday, ie add
>> externs to those headers.

> That solution seems fine, too.

Great.

> This comment should be clarified:
> +	# This redundant extern declaration is needed to silence headerscheck
> +	# warnings with some gcc versions.
> You could just write
> # silence -Wmissing-variable-declarations
> which also appears elsewhere in the code.

I compromised on writing "redundant declaration to silence
-Wmissing-variable-declarations", and pushed it.

			regards, tom lane





view thread (8+ messages)

Message-ID: <2159707.1756478859@sss.pgh.pa.us>
Permalink:  ../2159707.1756478859@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2159707.1756478859@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: headerscheck warnings with late-model gcc
  In-Reply-To: <2159707.1756478859@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox