agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: legrand legrand <legrand_legrand@hotmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Date: Thu, 2 Apr 2020 13:04:28 -0700 (MST)
Message-ID: <1585857868967-0.post@n3.nabble.com> (raw)
In-Reply-To: <13923268-bad9-80f9-2542-5fd5e8b8c500@oss.nttdata.com>
References: <1c348d6a-02e5-ef14-b9e7-22f7f36fcee1@oss.nttdata.com>
<CAOBaU_YMDofrfRrA4c_kNfFd4ZtwtoTy1XmnBom7rwyVGeFTDw@mail.gmail.com>
<8c6449d4-5fd7-f544-182b-a4bb7da1d18c@oss.nttdata.com>
<20200331060307.e7kypfynz7jous62@nol>
<ac44fd08-5923-c0f7-742d-952a6f5a14a3@oss.nttdata.com>
<20200331073321.bhnx2p63gp5px37f@nol>
<f2b4e098-1b96-e1a8-f601-a0908c9ff8c4@oss.nttdata.com>
<20200331184217.tf3x534uz4vusgmp@nol>
<bd27f039-5285-1fb7-5ed4-57f870c8a5a4@oss.nttdata.com>
<13923268-bad9-80f9-2542-5fd5e8b8c500@oss.nttdata.com>
Fujii Masao-4 wrote
> On 2020/04/01 18:19, Fujii Masao wrote:
>
> Finally I pushed the patch!
> Many thanks for all involved in this patch!
>
> As a remaining TODO item, I'm thinking that the document would need to
> be improved. For example, previously the query was not stored in pgss
> when it failed. But, in v13, if pgss_planning is enabled, such a query is
> stored because the planning succeeds. Without the explanation about
> that behavior in the document, I'm afraid that users will get confused.
> Thought?
>
> Regards,
>
> --
> Fujii Masao
> Advanced Computing Technology Center
> Research and Development Headquarters
> NTT DATA CORPORATION
Thank you all for this work and especially to Julian for its major
contribution !
Regarding the TODO point: Yes I agree that it can be improved.
My proposal:
"Note that planning and execution statistics are updated only at their
respective end phase, and only for successfull operations.
For exemple executions counters of a long running SELECT query,
will be updated at the execution end, without showing any progress
report in the interval.
Other exemple, if the statement is successfully planned but fails in
the execution phase, only its planning statistics are stored.
This may give uncorrelated plans vs calls informations."
Regards
PAscal
--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html
view thread (127+ messages) latest in thread
Message-ID: <1585857868967-0.post@n3.nabble.com>
Permalink: ../1585857868967-0.post@n3.nabble.com/
Also on: postgresql.org/message-id/1585857868967-0.post@n3.nabble.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: legrand_legrand@hotmail.com
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
In-Reply-To: <1585857868967-0.post@n3.nabble.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox