From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
Date: Sat, 03 Aug 2019 12:59:39 -0400
Message-ID: <16320.1564851579@sss.pgh.pa.us> (raw)
In-Reply-To: <20190803124111.2aaddumd7url5wmq@development>
References: <56aff4f3-dec8-f462-7feb-0938411b04a6@2ndquadrant.com>
<CAA4eK1+JMm=tvx720y6jhD8pdzt=HdS1-TwQwkARib2pwK8EvQ@mail.gmail.com>
<20190802222254.qsvqjtkwte464lu3@development>
<31697.1564784856@sss.pgh.pa.us>
<CAOuzzgqNyQM_z0biEEBVBK9WcaLmbCyWrd5xTdf-Oxb_9pntLA@mail.gmail.com>
<32681.1564786027@sss.pgh.pa.us>
<CAOuzzgpDj4kLNh7=bfEYv4zXrLgRziMogcXFSHzrhn74xjYXyQ@mail.gmail.com>
<20190803004558.jfkbngi6g64eaqku@alap3.anarazel.de>
<CAOuzzgpuH+uvT3Yvw5KC=keEqGifSc4eXQ6DB=yrowYyre2YvA@mail.gmail.com>
<20190803010802.rs3cz2kjq4dl4olu@alap3.anarazel.de>
<20190803124111.2aaddumd7url5wmq@development>
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> On Fri, Aug 02, 2019 at 06:08:02PM -0700, Andres Freund wrote:
>> We're WAY WAY past feature freeze. This isn't the time to rewrite guc.c,
>> guc-file.l to be suitable for running outside of a backend environment.
> Right. And even if we had the code, it's not quite backpatchable (which
> we probably should do, considering this is a general ALTER SYSTEM issue,
> so not pg12-only).
> Not to mention there's no clear consensus this is actually desirable.
> I'd argue forcing external tools (written in arbitrary language) to use
> this library (written in C), just to modify a "stupid" text file is a
> bit overkill. IMO duplicates don't make the file invalid, we should
> handle that correctly/gracefully, so I don't see why external tools
> could not simply append to the file. We can deduplicate the file when
> starting the server, on ALTER SYSTEM, or some other time.
Yup. I'd also point out that even if we had a command-line tool of this
sort, there would be scenarios where it's not practical or not convenient
to use. We need not go further than "my tool needs to work with existing
PG releases" to think of good examples.
I think we should just accept the facts on the ground, which are that
some tools modify pg.auto.conf by appending to it, and say that that's
supported as long as the file doesn't get unreasonably long.
I'm not at all on board with inventing a requirement for pg.auto.conf
to track its modification history. I don't buy that that's a
widespread need in the first place; if I did buy it, that file
itself is not where to keep the history; and in any case, it'd be
a new feature and it's way too late for v12.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com, andres@anarazel.de, sfrost@snowman.net, amit.kapila16@gmail.com, ian.barwick@2ndquadrant.com, robertmhaas@gmail.com
Subject: Re: [PATCH] Stop ALTER SYSTEM from making bad assumptions
In-Reply-To: <16320.1564851579@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox