pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Intermittent buildfarm failures on wrasse
Date: Fri, 15 Apr 2022 11:14:13 -0400
Message-ID: <1643035.1650035653@sss.pgh.pa.us> (raw)
In-Reply-To: <1637671.1650032132@sss.pgh.pa.us>
References: <1521388.1649953580@sss.pgh.pa.us>
	<1547912.1649971995@sss.pgh.pa.us>
	<CAH2-Wz=DHY2LV7=2aVd=qz6AbQhFK7KJRNL5ZwgB7dyno_gzdg@mail.gmail.com>
	<1553951.1649975018@sss.pgh.pa.us>
	<CAH2-WzngTjUk_65ESmrMf40WTqasrmWG0gpwnvcN+mXsoXT7qQ@mail.gmail.com>
	<CAH2-WznXXkkfE_y9ieaHkEQj31HeMAqJBtJPmDY+EpyVg1QywQ@mail.gmail.com>
	<1570894.1649986347@sss.pgh.pa.us>
	<20220415015249.kfsqxujrf2bn2wz6@alap3.anarazel.de>
	<20220415024515.GA862547@rfd.leadboat.com>
	<20220415051205.6abhlilh6fnjgohr@alap3.anarazel.de>
	<20220415052125.GD862547@rfd.leadboat.com>
	<1637671.1650032132@sss.pgh.pa.us>

I wrote:
> the vacuum in test_setup sees
> ...
>         removable cutoff: 724, older by 26 xids when operation ended
> ...

BTW, before I forget: the wording of this log message is just awful.
On first sight, I thought that it meant that we'd computed OldestXmin
a second time and discovered that it advanced by 26 xids while the VACUUM
was running.  Looking at the code, I see that's not so:

            diff = (int32) (ReadNextTransactionId() - OldestXmin);
            appendStringInfo(&buf,
                             _("removable cutoff: %u, older by %d xids when operation ended\n"),
                             OldestXmin, diff);

but good luck understanding what it actually means from the message
text alone.  I think more appropriate wording would be something like

"removable cutoff: %u, which was %d xids old when operation ended\n"

Also, is it really our practice to spell XID in lower-case in
user-facing messages?

Thoughts, better ideas?

			regards, tom lane





view thread (88+ messages)  latest in thread

Message-ID: <1643035.1650035653@sss.pgh.pa.us>
Permalink:  ../1643035.1650035653@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1643035.1650035653@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, noah@leadboat.com, pg@bowt.ie, dgrowleyml@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Intermittent buildfarm failures on wrasse
  In-Reply-To: <1643035.1650035653@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox