From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Augment every test postgresql.conf
Date: Sat, 29 Dec 2018 22:46:31 -0500
Message-ID: <16623.1546141591@sss.pgh.pa.us> (raw)
In-Reply-To: <20181230024014.GA181668@gust.leadboat.com>
References: <20181229021950.GA3302966@rfd.leadboat.com>
<20181230024014.GA181668@gust.leadboat.com>
Noah Misch <noah@leadboat.com> writes:
> Looking more closely, we already have the TEMP_CONFIG variable and apply it to
> everything except TAP suites. Closing that gap, as attached, is enough. The
> buildfarm client uses TEMP_CONFIG to implement its extra_config setting, so
> this will cause extra_config to start applying to TAP suites.
Seems reasonable, but it might be a good idea to warn the buildfarm-owners
list before committing. (Although I guess it wouldn't be hard to check
the buildfarm database to see if anyone is putting anything interesting
into their critters' TEMP_CONFIG.)
Also, if we're to do this, it seems like applying it to back branches
would be helpful --- but will it work in all the back branches?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com
Subject: Re: Augment every test postgresql.conf
In-Reply-To: <16623.1546141591@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox