pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Eugene Kazakov <e.kazakov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Small PATCH: check of 2 Perl modules
Date: Mon, 15 Feb 2016 10:02:12 -0500
Message-ID: <16821.1455548532@sss.pgh.pa.us> (raw)
In-Reply-To: <56C1D959.7030105@sigaev.ru>
References: <56BDDC20.9020506@postgrespro.ru>
	<56C1D3D3.7010001@gmx.net>
	<56C1D959.7030105@sigaev.ru>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Teodor Sigaev <teodor@sigaev.ru> writes:
>> On 2/12/16 8:20 AM, Eugene Kazakov wrote:
>>> TAP-tests need two Perl modules: Test::More and IPC::Run.

>> I think those modules are part of a standard Perl installation.

> IPC::Run is not. At least for perl from ports tree in FreeBSD.

Yeah, I remember having had to install IPC::Run from CPAN, and a couple
of other things too (but I don't remember Test::More specifically), when
setting up some of my buildfarm critters.  It's likely that a lot of
distros bundle these, but I don't think IPC::Run is in a basic
built-from-source Perl.

The real question though is do we need a configure check at all.

Given that investigation into a CMake conversion is actively going
on, I'm hesitant to move the goalposts for it by introducing a brand
new type of configure check.  Maybe we should punt this issue until
that patch is either accepted or decisively rejected.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (13+ messages)  latest in thread

Message-ID: <16821.1455548532@sss.pgh.pa.us>
Permalink:  ../16821.1455548532@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/16821.1455548532@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, teodor@sigaev.ru, peter_e@gmx.net, e.kazakov@postgrespro.ru
  Subject: Re: Small PATCH: check of 2 Perl modules
  In-Reply-To: <16821.1455548532@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox