pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: vitus@wagner.pp.ru, Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: master make check fails on Solaris 10
Date: Thu, 18 Jan 2018 09:56:48 -0500
Message-ID: <16822.1516287408@sss.pgh.pa.us> (raw)
In-Reply-To: <0e183c12a68af526ebc03c5c26206c44@postgrespro.ru>
References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru>
	<20180111173938.jimybeayp2u5mmup@alap3.anarazel.de>
	<31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru>
	<fc3c1b52d2d4121cccfc13635005bbd0@postgrespro.ru>
	<1232.1515780057@sss.pgh.pa.us>
	<b946893927ccfd87146d8a7c9f3bbe29@postgrespro.ru>
	<15299.1515867055@sss.pgh.pa.us>
	<a5559105243efcf6fb619d86c5702115@postgrespro.ru>
	<18209.1516059711@sss.pgh.pa.us>
	<90ab676392c8f9c84431976147097cf0@postgrespro.ru>
	<17897.1516202926@sss.pgh.pa.us>
	<1c70bab595a37ffa3a7fafea29fa6f55@postgrespro.ru>
	<31743.1516206789@sss.pgh.pa.us>
	<0e183c12a68af526ebc03c5c26206c44@postgrespro.ru>

Marina Polyakova <m.polyakova@postgrespro.ru> writes:
> Applying your patch on commit f033462d8f77c40b7d6b33c5116e50118fb4699d 
> and using the configuration command from [1], I got:
> checking for __int128... yes
> checking for __int128 alignment bug... broken
> ...
> And make check-world passes. Victor said that he used a much simpler 
> configuration command, and I'm trying to figure out what's changed..

Weird.  Maybe the gcc bug only manifests with certain optimization
flags?  That's not what I'd have expected from Victor's theory about
why the code is wrong, but if it only shows up some of the time,
it's hard to think of another explanation.

> P.S. I found the trailing whitespace in line 80:
> ! int128a q;

Ah, thanks.  Probably git would've whined about that when I went
to commit, but it's good to catch sooner.

			regards, tom lane




view thread (46+ messages)  latest in thread

Message-ID: <16822.1516287408@sss.pgh.pa.us>
Permalink:  ../16822.1516287408@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/16822.1516287408@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, m.polyakova@postgrespro.ru, andres@anarazel.de, alvherre@alvh.no-ip.org
  Subject: Re: master make check fails on Solaris 10
  In-Reply-To: <16822.1516287408@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox