From: David Steele <david@pgmasters.net>
To: Heikki Linnakangas <hlinnaka@iki.fi>
To: Cary Huang <cary.huang@highgo.ca>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind copies
Date: Thu, 25 Mar 2021 09:32:05 -0400
Message-ID: <171fd136-d523-57fd-6f03-26eea9427136@pgmasters.net> (raw)
In-Reply-To: <b2ebc855-61e3-818b-d6b8-cddf3e3d8816@iki.fi>
References: <f67feb24-5833-88cb-1020-19a4a2b83ac7@iki.fi>
<f67feb24-5833-88cb-1020-19a4a2b83ac7@iki.fi>
<160807013024.1158.705820212542993455.pgcf@coridan.postgresql.org>
<b2ebc855-61e3-818b-d6b8-cddf3e3d8816@iki.fi>
On 1/22/21 8:26 AM, Heikki Linnakangas wrote:
> On 16/12/2020 00:08, Cary Huang wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world: tested, passed
>> Implements feature: tested, passed
>> Spec compliant: tested, passed
>> Documentation: not tested
>>
>> Hello
>>
>> The patch seems to do as described and the regression and tap tests
>> are passing
>> + /*
>> + * A local source is not expected to change while we're
>> rewinding, so check
>> + * that we size of the file matches our earlier expectation.
>> + */
>> Is this a tyoo?
>
> Yep, thanks! Attached is a new patch version, with that fixed and
> rebased. No other changes.
Cary, does this patch look ready to commit? If so, please change the
state in the CF entry to "Ready for Committer".
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, hlinnaka@iki.fi, cary.huang@highgo.ca, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_rewind copies
In-Reply-To: <171fd136-d523-57fd-6f03-26eea9427136@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox