From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org, david@justatheory.com, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: Fri, 17 Oct 2025 15:27:10 -0400
Message-ID: <1728139.1760729230@sss.pgh.pa.us> (raw)
In-Reply-To: <aPKUzk2xFhZBbWmz@nathan>
References: <aPJ03E2itovDBcKX@nathan>
<1713509.1760721320@sss.pgh.pa.us>
<aPKFmL8VjOKNVLcw@nathan>
<1723302.1760726712@sss.pgh.pa.us>
<aPKUzk2xFhZBbWmz@nathan>
Nathan Bossart <nathandbossart@gmail.com> writes:
> I've attached a first try. You'll notice that I have borrowed heavily from
> .git-blame-ignore-revs. Some other things that might be worthwhile:
There would need to be an initial entry at the time the file is
created, which would presumably point to some commit shortly before
the .0 version stamp is applied (or maybe we'd choose to do it around
rc1). The mockup should include that.
I'd be slightly inclined to have just one non-comment line, which
is the active reference hash value, and all the rest be comments.
The way you have it here requires the reading code to be smart
about end-of-line comments, which is code complexity we don't need
and doesn't seem amazingly legible either. OTOH, the precedent of
.git-blame-ignore-revs may be worth following regardless of our
personal druthers.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, andrew@dunslane.net
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
In-Reply-To: <1728139.1760729230@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox