pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Antonin Houska <ah@cybertec.at>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: thomas.munro@enterprisedb.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Memory leaks in BufFileOpenShared()
Date: Fri, 15 Jun 2018 10:42:33 +0200
Message-ID: <17325.1529052153@localhost> (raw)
In-Reply-To: <20180615.172208.29879168502273778.t-ishii@sraoss.co.jp>
References: <11329.1529045692@localhost>
	<20180615.162003.2258832502225295119.t-ishii@sraoss.co.jp>
	<16139.1529049566@localhost>
	<20180615.172208.29879168502273778.t-ishii@sraoss.co.jp>

Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

> The changes were made by this commit to add infrastructure for sharing
> temporary files between backends, according to the author (Thomas
> Munro).
> 
> https://git.postgresql.org/pg/commitdiff/dc6c4c9dc2a111519b76b22daaaac86c5608223b
> 
> Your proposal looks reasonable but I would like to hear from Thomas's
> opinion as well.

o.k. He can actually have different feeling about details, e.g. if a new
function makeBufFileCommon() should be introduced or if makeBufFile() should
do the common settings. In the latter case, BufFileCreateTemp() would have to
do more work than it does now.

-- 
Antonin Houska
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26, A-2700 Wiener Neustadt
Web: https://www.cybertec-postgresql.com




view thread (8+ messages)  latest in thread

Message-ID: <17325.1529052153@localhost>
Permalink:  ../17325.1529052153@localhost/
Also on:    postgresql.org/message-id/17325.1529052153@localhost

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ah@cybertec.at, ishii@sraoss.co.jp, thomas.munro@enterprisedb.com
  Subject: Re: Memory leaks in BufFileOpenShared()
  In-Reply-To: <17325.1529052153@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox