pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Steele <david@pgmasters.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Stephen Frost <sfrost@snowman.net>
Subject: Re: C99 compliance for src/port/snprintf.c
Date: Wed, 15 Aug 2018 14:09:08 -0400
Message-ID: <17667.1534356548@sss.pgh.pa.us> (raw)
In-Reply-To: <6ae46827-45de-b3e7-4f19-01f9c48b28d4@pgmasters.net>
References: <17245.1534289329@sss.pgh.pa.us>
	<CA+TgmoaanyYh9KG49yWdhzU72Ngh7XG5Gs9rtceQfBg6WFaybA@mail.gmail.com>
	<9456.1534347706@sss.pgh.pa.us>
	<20180815155237.pz5fgfmdo4cgqjta@alap3.anarazel.de>
	<CA+TgmoYvHzFkwChsamwbBrLNJRcRq+fyTwveFaN_YOWUsRnfpw@mail.gmail.com>
	<11138.1534349838@sss.pgh.pa.us>
	<6ae46827-45de-b3e7-4f19-01f9c48b28d4@pgmasters.net>

David Steele <david@pgmasters.net> writes:
> On 8/15/18 12:17 PM, Tom Lane wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> Personally, I'd prefer to
>>> continue avoiding // comments and intermingled declarations of
>>> variables and code on grounds of style and readability.

>> ... which I agree with.

> We already have -Wdeclaration-after-statement to prevent mixed
> declarations.  Not sure what to do about comments except manual enforcement.

pgindent will change // comments to /* style, so at least on the timescale
of a release cycle, we have enforcement for that.

			regards, tom lane




view thread (46+ messages)  latest in thread

Message-ID: <17667.1534356548@sss.pgh.pa.us>
Permalink:  ../17667.1534356548@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/17667.1534356548@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, david@pgmasters.net, robertmhaas@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, sfrost@snowman.net
  Subject: Re: C99 compliance for src/port/snprintf.c
  In-Reply-To: <17667.1534356548@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox