From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Yet another (minor) fix in BRIN
Date: Sat, 07 Nov 2020 22:45:26 -0500
Message-ID: <1776964.1604807126@sss.pgh.pa.us> (raw)
In-Reply-To: <20201108015137.GA7294@alvherre.pgsql>
References: <20201108015137.GA7294@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2020-Nov-08, Tomas Vondra wrote:
>> While rebasing some of the BRIN patches, I noticed some of the code in
>> brin_memtuple_initialize is duplicated. This happened in 8bf74967dab
>> which moved some of the code from brin_new_memtuple, not removing the
>> shared pieces. In practice this is benign, of course.
>>
>> Barring objections I'll get the attached fix committed and backpatched.
> LGTM, thanks for noticing.
The weekend before stable-branch releases is probably not the best
time to be pushing "minor" fixes into those branches. I got my
fingers burned today, and so did Peter. Don't follow our example ;-)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, tomas.vondra@enterprisedb.com
Subject: Re: Yet another (minor) fix in BRIN
In-Reply-To: <1776964.1604807126@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox