pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Cc: pgbf@twiska.com, pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
Date: Sun, 23 Jan 2022 21:25:04 -0500
Message-ID: <1787748.1642991104@sss.pgh.pa.us> (raw)
In-Reply-To: <Ye4M5U98cseJ6OoL@paquier.xyz>
References: <20220116071210.GA735692@rfd.leadboat.com>
	<CA+hUKGLoV=wYa301GWaQUb7zb4cNE4QLqnik_QbHe-=3kpp=Ew@mail.gmail.com>
	<20220116210241.GC756210@rfd.leadboat.com>
	<20220122185241.GA1095169@rfd.leadboat.com>
	<CA+hUKGLbtEfCMXA9H+W6R-FRS7yojs5TdfqbNdEetTa7pB4Khw@mail.gmail.com>
	<20220123232927.GA1131882@rfd.leadboat.com>
	<78685FA0-EEC6-4AFB-B323-C37A99C82563@anarazel.de>
	<20220124011759.GC1131882@rfd.leadboat.com>
	<20220124014054.cd4yranmj5wyf7g7@alap3.anarazel.de>
	<20220124021007.GA1170596@rfd.leadboat.com>
	<Ye4M5U98cseJ6OoL@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Sun, Jan 23, 2022 at 06:10:07PM -0800, Noah Misch wrote:
>> Could do that.  Every run that doesn't get the flaky failure will print a
>> message like "TODO passed:  3-5", though the test file could mitigate that by
>> declaring the TODO only on configurations where we expect a failure.  The
>> 027_stream_regress.pl trouble involves reaching a die(), not failing a test in
>> this sense, so that one would take more work.

> Using a TODO has the advantage to allow the tests to run on a periodic
> basis, even if they could fail in this unexpected way.

I'm okay with this *if* the TODO marking can be constrained to platforms
where we know there's a problem.  Otherwise I'm afraid it will mask
unexpected problems.

			regards, tom lane





view thread (35+ messages)  latest in thread

Message-ID: <1787748.1642991104@sss.pgh.pa.us>
Permalink:  ../1787748.1642991104@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1787748.1642991104@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, noah@leadboat.com, andres@anarazel.de, thomas.munro@gmail.com
  Subject: Re: XLogReadRecord() error in XlogReadTwoPhaseData()
  In-Reply-To: <1787748.1642991104@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox