From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ilya Gladyshev <ilya.v.gladyshev@gmail.com>
Cc: shiy.fnst@fujitsu.com <shiy.fnst@fujitsu.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: Segfault on logical replication to partitioned table with foreign children
Date: Wed, 02 Nov 2022 12:37:42 -0400
Message-ID: <1787918.1667407062@sss.pgh.pa.us> (raw)
In-Reply-To: <1361869.1667329814@sss.pgh.pa.us>
References: <6b93e3748ba43298694f376ca8797279d7945e29.camel@gmail.com>
<CAFiTN-vvnrvHeUibhwhnJNgTyE70DcBTgXPws3iO7HVM9TWANg@mail.gmail.com>
<188734.1667137161@sss.pgh.pa.us>
<OSZPR01MB6310B855B1B90FEE433A98F4FD379@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<04b5212cd549ee3c8efc63f6a92d85d5463bfdf1.camel@gmail.com>
<1361869.1667329814@sss.pgh.pa.us>
Since we're getting pretty close to the next set of back-branch releases,
I went ahead and pushed a minimal fix along the lines suggested by Shi Yu.
(I realized that there's a second ExecFindPartition call in worker.c that
also needs a check.) We still can at leisure think about refactoring
CheckSubscriptionRelkind to avoid unnecessary lookups. I think that
is something we should do only in HEAD; it'll just be a marginal savings,
not worth the risks of API changes in stable branches. The other loose
end is whether to worry about a regression test case. I'm inclined not
to bother. The only thing that isn't getting exercised is the actual
ereport, which probably isn't in great need of routine testing.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, ilya.v.gladyshev@gmail.com, shiy.fnst@fujitsu.com, dilipbalaut@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Segfault on logical replication to partitioned table with foreign children
In-Reply-To: <1787918.1667407062@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox