From: Manu <manuelreyesbravo@gmail.com>
To: Antonin Houska <ah@cybertec.at>
Cc: shihao zhong <zhong950419@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: REPACK enhancements
Date: Fri, 13 Nov 2026 22:23:07 -0300
Message-ID: <179461938749.1794772.16290685916698475395@gmail.com> (raw)
In-Reply-To: <309062.1794403598@chrudos>
References: <309062.1794403598@chrudos>
Hi Antonin,
On Wed, Nov 11, 2026 at 2:26 PM Antonin Houska <ah@cybertec.at> wrote:
> I don't really understand why 'xmax' should be involved. The original
> assertion checks exactly whether 'add_to_max' is the "current transaction" and
> I tried to disable it exactly when the function is called by REPACK (to replay
> data changes). However, 'xmax' can be invalid even in cases unrelated to
> REPACK (i.e. when doing "regular" UPDATE / DELETE). Thus what you propose
> makes the assertion a bit less useful.
You're right. I used xmax because the replay always gets here with
xmax invalid, so the code below never looks at the current
transaction. But a regular UPDATE or DELETE usually gets here the
same way, so for them the assertion would check nothing, and my
"keeps the old check" was wrong. Leaving it commented out, as in v05,
is fine with me.
Regards,
Manu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: manuelreyesbravo@gmail.com, ah@cybertec.at, zhong950419@gmail.com
Subject: Re: REPACK enhancements
In-Reply-To: <179461938749.1794772.16290685916698475395@gmail.com>
References: <309062.1794403598@chrudos> <179461938749.1794772.16290685916698475395@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox