From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: HAVE_WORKING_LINK still needed?
Date: Fri, 28 Feb 2020 11:55:05 -0500
Message-ID: <17964.1582908905@sss.pgh.pa.us> (raw)
In-Reply-To: <72fff73f-dc9c-4ef4-83e8-d2e60c98df48@2ndquadrant.com>
References: <72fff73f-dc9c-4ef4-83e8-d2e60c98df48@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I came across the HAVE_WORKING_LINK define in pg_config_manual.h.
> AFAICT, hard links are supported on Windows and Cygwin in the OS
> versions that we support, and pg_upgrade already contains the required
> shim. It seems to me we could normalize and simplify that, as in the
> attached patches. (Perhaps rename durable_link_or_rename() then.) I
> successfully tested on MSVC, MinGW, and Cygwin.
I don't have any way to test on Windows, but this patchset passes
eyeball review. +1 for getting rid of the special cases.
Also +1 for s/durable_link_or_rename/durable_link/.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
Subject: Re: HAVE_WORKING_LINK still needed?
In-Reply-To: <17964.1582908905@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox