pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Smolkin Grigory <smallkeen@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: race condition in pg_class
Date: Thu, 11 Sep 2025 12:36:04 -0400
Message-ID: <1802710.1757608564@sss.pgh.pa.us> (raw)
In-Reply-To: <20240512232923.aa.nmisch@google.com>
References: <CAMp+ueZQz3yDk7qg42hk6-9gxniYbp-=bG2mgqecErqR5gGGOA@mail.gmail.com>
	<20231027044404.7e.nmisch@google.com>
	<20231027184832.9b.nmisch@google.com>
	<1596629.1698435146@sss.pgh.pa.us>
	<20231027214946.79.nmisch@google.com>
	<1617596.1698446455@sss.pgh.pa.us>
	<20231027232612.99.nmisch@google.com>
	<20231102030915.d3.nmisch@google.com>
	<20240512232923.aa.nmisch@google.com>

[ blast-from-the-past department ]

Noah Misch <noah@leadboat.com> writes:
> I'm attaching patches implementing the LockTuple() design.

inplace010-tests-v1.patch from this message, committed as
0844b3968, contains this bit:

new file mode 100644
index 00000000000..0367c0e37ab
--- /dev/null
+++ b/src/test/regress/sql/database.sql
@@ -0,0 +1,17 @@
+CREATE DATABASE regression_tbd
+   ENCODING utf8 LC_COLLATE "C" LC_CTYPE "C" TEMPLATE template0;
+ALTER DATABASE regression_tbd RENAME TO regression_utf8;
+ALTER DATABASE regression_utf8 SET TABLESPACE regress_tblspace;
+ALTER DATABASE regression_utf8 RESET TABLESPACE;
+ALTER DATABASE regression_utf8 CONNECTION_LIMIT 123;
+

It emerges that the "ALTER DATABASE regression_utf8 RESET TABLESPACE"
command is a complete no-op [1].  I am guessing that that was not the
behavior you had in mind, and am wondering if we are losing any test
coverage thereby.  Did you have a specific reason for manipulating the
TABLESPACE property and not some random GUC setting?

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/30783e-68c28a00-9-41004480%40130449754





view thread (86+ messages)  latest in thread

Message-ID: <1802710.1757608564@sss.pgh.pa.us>
Permalink:  ../1802710.1757608564@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1802710.1757608564@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, smallkeen@gmail.com
  Subject: Re: race condition in pg_class
  In-Reply-To: <1802710.1757608564@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox