pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Yurii Rashkovskii <yrashk@omnigres.com>
Cc: Andrei Lepikhov <lepihov@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add Postgres module info
Date: Wed, 26 Mar 2025 22:45:22 -0400
Message-ID: <1815171.1743043522@sss.pgh.pa.us> (raw)
In-Reply-To: <CAG=VW14mctsR543gpzLCuJ9JgJqwa=ptmBfGvxEjs+k8Jf7-Bg@mail.gmail.com>
References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com>
	<506788.1733941263@sss.pgh.pa.us>
	<2c215c98-f713-4c5b-b21a-a4b8fa41890b@gmail.com>
	<556341.1733967371@sss.pgh.pa.us>
	<0844622e-9967-409a-8038-470a36f1039c@gmail.com>
	<CAG=VW14ZmKDcxYs7irSvhVS+JeDg2W_gyR++L2GXEpzVVYQ+Yw@mail.gmail.com>
	<8b81a3c0-761f-4cfb-97c6-68819fe4d282@gmail.com>
	<982748.1734059835@sss.pgh.pa.us>
	<0e82bf8c-ae70-498d-861e-dba2bb154cad@gmail.com>
	<CAPpHfduL6=LdHco_+wCk=VQyZzEd5hjLi46jtV2gQbDrpXf5Gw@mail.gmail.com>
	<Z7Kmann0SyoP7kDr@paquier.xyz>
	<29d29c3e-ac9e-48cc-87b4-b1cfd8c2ede8@gmail.com>
	<992ec366-5c0d-4f23-a02e-30e663613f44@gmail.com>
	<4476e8cd-6427-4470-98a8-8d61b82d8b1e@gmail.com>
	<441661.1742683797@sss.pgh.pa.us>
	<d056f9fc-b29c-48c4-81ae-d81a5bb7b5f2@gmail.com>
	<796058.1742757002@sss.pgh.pa.us>
	<CA+Tgmob5maQdhTDAnQmy2=UjfeJYwQg8dexY5F+kgfWCKe54rw@mail.gmail.com>
	<1003653.1742831657@sss.pgh.pa.us>
	<f8608216-61d7-4885-b215-91e9d176386c@app.fastmail.com>
	<1085307.1742840674@sss.pgh.pa.us>
	<1! 613104.1743002108@sss.pgh.pa.us>
	<CAG=VW14mctsR543gpzLCuJ9JgJqwa=ptmBfGvxEjs+k8Jf7-Bg@mail.gmail.com>

Yurii Rashkovskii <yrashk@omnigres.com> writes:
> This recent patch is great but causes a small problem. It mixes designated
> and non-designated initializers, specifically in `PG_MODULE_MAGIC_DATA(0)`.

Ugh.  I felt a bit itchy about that, but my compiler wasn't
complaining...

Can you propose a specific change to clean it up?  I wanted to write
just "PG_MODULE_MAGIC_DATA()", but I'm not sure that's valid C either.

			regards, tom lane





view thread (52+ messages)  latest in thread

Message-ID: <1815171.1743043522@sss.pgh.pa.us>
Permalink:  ../1815171.1743043522@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1815171.1743043522@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, yrashk@omnigres.com, lepihov@gmail.com, euler@eulerto.com, robertmhaas@gmail.com, michael@paquier.xyz, aekorotkov@gmail.com
  Subject: Re: Add Postgres module info
  In-Reply-To: <1815171.1743043522@sss.pgh.pa.us>
  References: <dd4d1b59-d0fe-49d5-b28f-1e463b68fa32@gmail.com> <0844622e-9967-409a-8038-470a36f1039c@gmail.com> <CAG=VW14ZmKDcxYs7irSvhVS+JeDg2W_gyR++L2GXEpzVVYQ+Yw@mail.gmail.com> <8b81a3c0-761f-4cfb-97c6-68819fe4d282@gmail.com> <982748.1734059835@sss.pgh.pa.us> <0e82bf8c-ae70-498d-861e-dba2bb154cad@gmail.com> <CAPpHfduL6=LdHco_+wCk=VQyZzEd5hjLi46jtV2gQbDrpXf5Gw@mail.gmail.com> <Z7Kmann0SyoP7kDr@paquier.xyz> <29d29c3e-ac9e-48cc-87b4-b1cfd8c2ede8@gmail.com> <992ec366-5c0d-4f23-a02e-30e663613f44@gmail.com> <4476e8cd-6427-4470-98a8-8d61b82d8b1e@gmail.com> <441661.1742683797@sss.pgh.pa.us> <d056f9fc-b29c-48c4-81ae-d81a5bb7b5f2@gmail.com> <796058.1742757002@sss.pgh.pa.us> <CA+Tgmob5maQdhTDAnQmy2=UjfeJYwQg8dexY5F+kgfWCKe54rw@mail.gmail.com> <1003653.1742831657@sss.pgh.pa.us> <f8608216-61d7-4885-b215-91e9d176386c@app.fastmail.com> <1085307.1742840674@sss.pgh.pa.us> <CAG=VW14mctsR543gpzLCuJ9JgJqwa=ptmBfGvxEjs+k8Jf7-Bg@mail.gmail.com> <1815171.1743043522@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox