From: Tom Lane <tgl@sss.pgh.pa.us>
To: bt22nakamorit <bt22nakamorit@oss.nttdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: JUMBLE_SIZE macro in two files
Date: Tue, 04 Oct 2022 09:16:44 -0400
Message-ID: <1817528.1664889404@sss.pgh.pa.us> (raw)
In-Reply-To: <bb4ebd0412da9b1ac87a5eb2a3646bf1@oss.nttdata.com>
References: <bb4ebd0412da9b1ac87a5eb2a3646bf1@oss.nttdata.com>
bt22nakamorit <bt22nakamorit@oss.nttdata.com> writes:
> queryjumble.c and queryjumble.h both define a macro JUMBLE_SIZE = 1024.
> Since queryjumble.c includes queryjumble.h, the JUMBLE_SIZE definition
> in queryjumble.c should be deleted.
I would go more for taking it out of queryjumble.h. I see no
reason why that constant needs to be world-visible.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, bt22nakamorit@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: JUMBLE_SIZE macro in two files
In-Reply-To: <1817528.1664889404@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox