From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Better client reporting for "immediate stop" shutdowns
Date: Mon, 28 Dec 2020 15:01:50 -0500
Message-ID: <1819455.1609185710@sss.pgh.pa.us> (raw)
In-Reply-To: <20201228191428.p5bhcvd4ixsuyifd@alap3.anarazel.de>
References: <559291.1608587013@sss.pgh.pa.us>
<20201225230331.hru3u6obyy6j53tk@alap3.anarazel.de>
<1293510.1609007835@sss.pgh.pa.us>
<20201226191627.nowyox3chvk4mjhk@alap3.anarazel.de>
<1730644.1609179914@sss.pgh.pa.us>
<20201228191428.p5bhcvd4ixsuyifd@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> I don't think it needs to be done right now, but I again want to suggest
> it'd be nice if we split log levels into a bitmask. If we bits, separate
> from the log level, for do-not-log-to-client and do-not-log-to-server
> some of this code would imo look nicer.
Hmm, maybe. I agree that would be better done as a separate patch though.
I had a thought while looking at elog.c: we could further reduce the risk
of quickdie() crashing if we make it do what elog.c does when it gets into
error recursion trouble:
error_context_stack = NULL;
debug_query_string = NULL;
Not invoking error context callbacks would significantly reduce the
footprint of code that can be reached from quickdie's ereports, and
the current call stack isn't really relevant to a report of SIGQUIT
anyway. The argument for not reporting debug_query_string is a little
thinner, but if that string is long it could result in additional
palloc work inside elog.c, thus increasing the amount of stuff that
has to work to get the report out.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Better client reporting for "immediate stop" shutdowns
In-Reply-To: <1819455.1609185710@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox