pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Better client reporting for "immediate stop" shutdowns
Date: Tue, 29 Dec 2020 18:05:20 -0500
Message-ID: <2240761.1609283120@sss.pgh.pa.us> (raw)
In-Reply-To: <1819455.1609185710@sss.pgh.pa.us>
References: <559291.1608587013@sss.pgh.pa.us>
	<20201225230331.hru3u6obyy6j53tk@alap3.anarazel.de>
	<1293510.1609007835@sss.pgh.pa.us>
	<20201226191627.nowyox3chvk4mjhk@alap3.anarazel.de>
	<1730644.1609179914@sss.pgh.pa.us>
	<20201228191428.p5bhcvd4ixsuyifd@alap3.anarazel.de>
	<1819455.1609185710@sss.pgh.pa.us>

I wrote:
> I had a thought while looking at elog.c: we could further reduce the risk
> of quickdie() crashing if we make it do what elog.c does when it gets into
> error recursion trouble:
>             error_context_stack = NULL;
>             debug_query_string = NULL;

On closer inspection, there's not much need to touch debug_query_string
here, because elog.c only consults that for making log entries, which
we're suppressing.  I pushed it with just the error_context_stack reset.

			regards, tom lane





view thread (14+ messages)

Message-ID: <2240761.1609283120@sss.pgh.pa.us>
Permalink:  ../2240761.1609283120@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2240761.1609283120@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: Better client reporting for "immediate stop" shutdowns
  In-Reply-To: <2240761.1609283120@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox