pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: A few warnings on Windows
Date: Wed, 02 May 2018 00:28:54 -0400
Message-ID: <18264.1525235334@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=0xscPGb=VORui=ikec5OJ17t4hJG5KjEJk7B2+wUAJXA@mail.gmail.com>
References: <CAEepm=3=TDYEXUEcHpEx+Twc31wo7PA0oBAiNt6sWmq93MW02A@mail.gmail.com>
	<20180501083026.GB25848@paquier.xyz>
	<15083.1525207729@sss.pgh.pa.us>
	<CAEepm=2AQxJENLfhZzU-=AcxmHXbDXV=kEdzPh7hjQrmmuHxWQ@mail.gmail.com>
	<CAEepm=3Q9y5mUcheKZ2jC9yFn8jb9Z-5vF03WE0mPD-JskSZVQ@mail.gmail.com>
	<26880.1525217953@sss.pgh.pa.us>
	<CAEepm=1vo7zUaAvHcRnLieNQ2rbqDDoyjDXxWxJF_aUfWCY8Lg@mail.gmail.com>
	<CAEepm=0xscPGb=VORui=ikec5OJ17t4hJG5KjEJk7B2+wUAJXA@mail.gmail.com>

Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Wed, May 2, 2018 at 12:51 PM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> Perhaps that's what Peter E meant when he said "Windows could use some
>> manual adjustments in pg_config.h.win32 if anyone
>> cares"[1].  Should we just change this to 1?  I'm going to go and test
>> that now.  From googling sizeof(bool) am aware that ancient VC (before
>> 5.0 more than 20 years ago) had a header that defined bool as int, but
>> that seems irrelevant now, right?

> That compiles and runs the main checks (except tablespace which I
> suppress) cleanly for me and I assume it really is using
> stdbool.h this time.  Hopefully plperl will be happier this way.

Pushed.  I was slightly tempted to add a static assertion that
SIZEOF_BOOL == sizeof(bool), but there's not any obvious home
for such a thing, and it's probably just useless worrying anyway.

> Since my earlier test, a new entirely independent warning arrived with
> commit 41c912ca:

Ooops.

> Patch for that attached, too.

Pushed that too, thanks.

			regards, tom lane




view thread (21+ messages)  latest in thread

Message-ID: <18264.1525235334@sss.pgh.pa.us>
Permalink:  ../18264.1525235334@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/18264.1525235334@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, michael@paquier.xyz
  Subject: Re: A few warnings on Windows
  In-Reply-To: <18264.1525235334@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox