From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Should contrib modules install .h files?
Date: Thu, 02 Aug 2018 10:54:00 -0400
Message-ID: <1836.1533221640@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZB9fVOd-8ZSWLaKX_TVAV9y0+7YrUn8vbpAPL_4XmGPw@mail.gmail.com>
References: <87h8lhoevw.fsf@news-spur.riddles.org.uk>
<63819.1530544945@sss.pgh.pa.us>
<878t6to8j9.fsf@news-spur.riddles.org.uk>
<874lhho071.fsf@news-spur.riddles.org.uk>
<67427.1530738056@sss.pgh.pa.us>
<87po02m0bh.fsf@news-spur.riddles.org.uk>
<87in5tnafh.fsf@news-spur.riddles.org.uk>
<87efghn7js.fsf@news-spur.riddles.org.uk>
<87a7r5n4n2.fsf@news-spur.riddles.org.uk>
<87o9enb4h7.fsf@news-spur.riddles.org.uk>
<20180731201700.zfscje7clxiljvjl@alap3.anarazel.de>
<CAH2-Wz=imVrbydSkBH95y3w7ZU7XffE7-LW0R+LjfZrXnyz-dw@mail.gmail.com>
<11978.1533073999@sss.pgh.pa.us>
<CA+TgmoZB9fVOd-8ZSWLaKX_TVAV9y0+7YrUn8vbpAPL_4XmGPw@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> Yeah, I would have voted -1 if I'd realized that it was close. Now
> we're in a situation where we have patch not everyone likes not only
> in master (which is OK, because we've got a year to decide whether to
> change anything) but also in v11 (where we have a lot less time).
> That's not so great.
It seems like there were two separate areas of disagreement/questioning,
one being the file layout (whether to add per-extension subdirectories)
and then one about how one would actually use this, ie what would the
-I switch(es) look like and where would they get injected.
My impression is that there was consensus for per-extension
subdirectories, but the usage scenario isn't totally designed yet.
In principle, only the layout question has to be resolved to make
it OK to ship this in v11. On the other hand, if there's no
very practical way to use the per-extension subdirectory layout,
we might have to rethink that layout. So I'd be happier about this
if that question were answered promptly. Failing a satisfactory
answer in the near future, I think we need to revert in v11.
Also, "near future" means "before Monday". I don't want to ship beta3
with this in place if we end up reverting later, because it'd mean
thrashing packagers' file manifests, which they won't appreciate.
It might be best to revert in v11 for now, and then we can put it back
after beta3 if there's agreement that the questions are satisfactorily
resolved.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pg@bowt.ie, andres@anarazel.de, andrew@tao11.riddles.org.uk
Subject: Re: Should contrib modules install .h files?
In-Reply-To: <1836.1533221640@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox