pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Joe Conway <mail@joeconway.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Error-safe user functions
Date: Sun, 11 Dec 2022 13:29:57 -0500
Message-ID: <1863335.1670783397@sss.pgh.pa.us> (raw )
In-Reply-To: <b54e97be-7316-2cab-6969-bfac6ec88ca6@dunslane.net >
References: <4009543.1670422833@sss.pgh.pa.us >
<6acddf68-7cb7-e9e7-a5a7-0abc87b3c55b@dunslane.net >
<CAKFQuwYdQqQru9tpMpY4JpCEJ8OeN8kwmBG6DY2QyzE+5znA6Q@mail.gmail.com >
<4111458.1670444176@sss.pgh.pa.us >
<3211.1670452341@sss.pgh.pa.us >
<20221207233518.sudtaxn6omtvpzvr@awork3.anarazel.de >
<186288.1670517119@sss.pgh.pa.us >
<CA+TgmoZOhQ8FfWH9_r58tLtb=AwBn=7ugO2PHh6moR8jhYviUA@mail.gmail.com >
<20221208215836.3naznqmal2m32hzc@awork3.anarazel.de >
<512551.1670540229@sss.pgh.pa.us >
<20221209023351.l362yejerfoq3lfp@awork3.anarazel.de >
<633426.1670554790@sss.pgh.pa.us >
<01ff2051-806d-af2f-4f9e-793f7ba9a3f8@dunslane.net >
<778369.1670598993@sss.pgh.pa.us >
<5aaf7c66-9df9-21a9-1ff4-02c7848def52@dunslane.net >
<3bac9841-fe07-713d-fa42-606c225567d6@dunslane.net >
<1436686.1670701118@sss.pgh.pa.us >
<2b1e7d56-6f37-bad9-9702-053ab55ecf60@dunslane.net >
<1805344.1670779451@sss.pgh.pa.us >
<b54e97be-7316-2cab-6969-bfac6ec88ca6@dunslane.net >
Andrew Dunstan <andrew@dunslane.net> writes:
> Maybe as we work through the remaining input functions (there are about
> 60 core candidates left on my list) we should mark them with a comment
> if no adjustment is needed.
I did a quick pass through them last night. Assuming that we don't
need to touch the unimplemented input functions (eg for pseudotypes),
I count these core functions as still needing work:
aclitemin
bit_in
box_in
bpcharin
byteain
cash_in
cidin
cidr_in
circle_in
inet_in
int2vectorin
jsonpath_in
line_in
lseg_in
macaddr8_in
macaddr_in
multirange_in
namein
oidin
oidvectorin
path_in
pg_lsn_in
pg_snapshot_in
point_in
poly_in
range_in
regclassin
regcollationin
regconfigin
regdictionaryin
regnamespacein
regoperatorin
regoperin
regprocedurein
regprocin
regrolein
regtypein
tidin
tsqueryin
tsvectorin
uuid_in
varbit_in
varcharin
xid8in
xidin
xml_in
and these contrib functions:
hstore:
hstore_in
intarray:
bqarr_in
isn:
ean13_in
isbn_in
ismn_in
issn_in
upc_in
ltree:
ltree_in
lquery_in
ltxtq_in
seg:
seg_in
Maybe we should have a conversation about which of these are
highest priority to get to a credible feature. We clearly need
to fix the remaining SQL-spec types (varchar and bpchar, mainly).
At the other extreme, likely nobody would weep if we never fixed
int2vectorin, for instance.
I'm a little concerned about the cost-benefit of fixing the reg* types.
The ones that accept type names actually use the core grammar to parse
those. Now, we probably could fix the grammar to be non-throwing, but
it'd be very invasive and I'm not sure about the performance impact.
It might be best to content ourselves with soft reporting of lookup
failures, as opposed to syntax problems.
regards, tom lane
view thread (175+ messages) latest in thread
Message-ID: <1863335.1670783397@sss.pgh.pa.us>
Permalink: ../1863335.1670783397@sss.pgh.pa.us/
Also on: postgresql.org/message-id/1863335.1670783397@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, andres@anarazel.de, aekorotkov@gmail.com, robertmhaas@gmail.com, david.g.johnston@gmail.com, corey.huinker@gmail.com, alvherre@alvh.no-ip.org, mail@joeconway.com, n.gluhov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: Error-safe user functions
In-Reply-To: <1863335.1670783397@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox