pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Victor Wagner <vitus@wagner.pp.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: master make check fails on Solaris 10
Date: Wed, 17 Jan 2018 10:40:26 -0500
Message-ID: <18638.1516203626@sss.pgh.pa.us> (raw)
In-Reply-To: <20180117183229.2bbc6eb7@fafnir.local.vm>
References: <0d3a9fa264cebe1cb9966f37b7c06e86@postgrespro.ru>
	<20180111173938.jimybeayp2u5mmup@alap3.anarazel.de>
	<31a342fa6a025a8bdfc5b8b19c29d56d@postgrespro.ru>
	<fc3c1b52d2d4121cccfc13635005bbd0@postgrespro.ru>
	<1232.1515780057@sss.pgh.pa.us>
	<b946893927ccfd87146d8a7c9f3bbe29@postgrespro.ru>
	<15299.1515867055@sss.pgh.pa.us>
	<a5559105243efcf6fb619d86c5702115@postgrespro.ru>
	<18209.1516059711@sss.pgh.pa.us>
	<90ab676392c8f9c84431976147097cf0@postgrespro.ru>
	<16720.1516201657@sss.pgh.pa.us>
	<20180117183229.2bbc6eb7@fafnir.local.vm>

Victor Wagner <vitus@wagner.pp.ru> writes:
> On Wed, 17 Jan 2018 10:07:37 -0500
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yeah, I can work with this.  What I propose to do is use a somewhat
>> stripped-down version of this test as an AC_RUN_IFELSE test normally,
>> but if cross-compiling, fall back to just seeing if we can link.

> I'd suggest to add a configure option to switch off 128-bit support 
> (--disable-int128), especially for these cross-compile cases where link
> test cannot give us enough information to decide automatically.

I don't want to go there without some evidence that the problem is much
more widespread than it appears now.  A disable switch will be a permanent
documentation and maintenance overhead, plus anyone who puts it into
their build scripts will probably never remember to remove it :-(.
And how many people will be cross-compiling to Solaris/SPARC anyway?
(If there are any, they can always manually change pg_config.h ...)

			regards, tom lane




view thread (46+ messages)  latest in thread

Message-ID: <18638.1516203626@sss.pgh.pa.us>
Permalink:  ../18638.1516203626@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/18638.1516203626@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, vitus@wagner.pp.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: master make check fails on Solaris 10
  In-Reply-To: <18638.1516203626@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox